Limits slurs to a maximum height.

Limits slurs to a maximum height.

[MikeSol, 2011-08-02 23:27:47]

This patch is the one with which I found the problem in the build system.  While
its introduction of a +nan.0 somewhere in the works does not bode well for it,
all of the snippets in input/regression compile cleanly before the build system
crashes (see issue 1799), and I only see slight visual output changes on the
manual tests I ran.  It fixes huge slurs from a different angle (acting on the
height used in generate_curve).

Cheers,
MS

[pkx166h, 2011-08-02 23:50:27]

Hello, makes ok but during eg check I get:

--snip--

reading input/regression/out-test/tablature-tie-spanner-1.signature
Traceback (most recent call last):
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
1261, in <module>
    main ()
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
1258, in main
    compare_tree_pairs (zip (args[0::2], args[1::2]), out, options.threshold)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
970, in compare_tree_pairs
    data.compare_trees (dir1, dir2)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", 810,
in compare_trees
    self.compare_directories (dir1, dir2)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
841, in compare_directories
    self.compare_files (f1, f2)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
845, in compare_files
    self.compare_signature_files (f1, f2)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
877, in compare_signature_files
    file_link.add_file_compare (f1, f2)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
596, in add_file_compare
    s2 = read_signature_file (f2)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
331, in read_signature_file
    if e and not e.startswith ('#')]
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
325, in string_to_entry
    fields[2] = string_to_tup (fields[2])
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
321, in string_to_tup
    return tuple (map (float, s.split (' ')))
ValueError: invalid literal for float(): +nan.0
make: *** [local-check] Error 1
jlowe@jlowe-lilybuntu2:~/lilypond-git/build$

[x.scheuer_gmail.com, 2011-08-03 05:50:27]

On 3 August 2011 01:27,  <mtsolo@gmail.com> wrote:
>
> Reviewers: ,
>
> Message:
> This patch is the one with which I found the problem in the build
> system.  While its introduction of a +nan.0 somewhere in the works does
> not bode well for it, all of the snippets in input/regression compile
> cleanly before the build system crashes (see issue 1799), and I only see
> slight visual output changes on the manual tests I ran.  It fixes huge
> slurs from a different angle (acting on the height used in
> generate_curve).

I'm not in the programming stuff.
But if you limit slurs to a maximum height, please also make some tests
to check the effect on *cross-staff* slurs (they can have an huge
height, but in this case that would be **normal**).

Cheers,
Xavier

-- 
Xavier Scheuer <x.scheuer@gmail.com>

[MikeSol, 2011-08-03 06:48:50]

http://codereview.appspot.com/4843043/diff/1/lily/slur-configuration.cc
File lily/slur-configuration.cc (right):

http://codereview.appspot.com/4843043/diff/1/lily/slur-configuration.cc#newco...
lily/slur-configuration.cc:203: height = min (generate_max_height (state),
height);
Thanks Xavier!
This line (I think) covers that - I'll be able to confirm one I've applied the
patch to fix output-distance.py