Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5450)

Issue 48430043: Web:Introduction: Rename "Our Goal" box (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by uliska
Modified:
10 years, 3 months ago
Reviewers:
Graham Percival, dak, phileholmes, mail, c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Web:Introduction: Rename "Our Goal" box The content of this box was somewhat confusing and inconsistent. See http://lists.gnu.org/archive/html/lilypond-devel/2014-01/msg00011.html This commit tries to incorporate the suggestions made in this thread as far as I considered appropriate.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Suggestion after discussion #

Patch Set 3 : reverting the box title (finally) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M Documentation/web/introduction.itexi View 1 2 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9
uliska
10 years, 3 months ago (2014-01-07 09:24:53 UTC) #1
PhilEHolmes
Please see my comment below. https://codereview.appspot.com/48430043/diff/1/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (right): https://codereview.appspot.com/48430043/diff/1/Documentation/web/introduction.itexi#newcode14 Documentation/web/introduction.itexi:14: @subheading Our Mission I ...
10 years, 3 months ago (2014-01-07 10:17:47 UTC) #2
uliska
https://codereview.appspot.com/48430043/diff/1/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (right): https://codereview.appspot.com/48430043/diff/1/Documentation/web/introduction.itexi#newcode14 Documentation/web/introduction.itexi:14: @subheading Our Mission On 2014/01/07 10:17:47, PhilEHolmes wrote: > ...
10 years, 3 months ago (2014-01-07 10:45:22 UTC) #3
mail_philholmes.net
----- Original Message ----- From: <lilyliska@googlemail.com> To: <phileholmes@googlemail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Tuesday, January 07, ...
10 years, 3 months ago (2014-01-07 10:55:35 UTC) #4
dak
On 2014/01/07 10:45:22, uliska wrote: > https://codereview.appspot.com/48430043/diff/1/Documentation/web/introduction.itexi > File Documentation/web/introduction.itexi (right): > > https://codereview.appspot.com/48430043/diff/1/Documentation/web/introduction.itexi#newcode14 > ...
10 years, 3 months ago (2014-01-07 11:25:15 UTC) #5
uliska
Suggestion after discussion
10 years, 3 months ago (2014-01-07 12:17:42 UTC) #6
c_sorensen
On Jan 7, 2014, at 3:56 AM, "Phil Holmes" <mail@philholmes.net> wrote: > ----- Original Message ...
10 years, 3 months ago (2014-01-07 13:32:23 UTC) #7
uliska
reverting the box title (finally)
10 years, 3 months ago (2014-01-07 19:21:23 UTC) #8
Graham Percival
10 years, 3 months ago (2014-01-09 09:32:01 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b