Issue 4841048: Add glReadBuffer to GrGLInterface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4841048: Add glReadBuffer to GrGLInterface (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bsalomon

Modified:
13 years, 3 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -1 line)			Patch
M	gpu/include/GrGLInterface.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	gpu/src/GrGLInterface.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/src/android/GrGLDefaultInterface_android.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/src/ios/GrGLDefaultInterface_iOS.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/src/mac/GrGLDefaultInterface_mac.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/src/mesa/GrGLDefaultInterface_mesa.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/src/unix/GrGLDefaultInterface_unix.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/src/win/GrGLDefaultInterface_win.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

On 2011/08/03 13:43:58, bsalomon wrote: > Turns out we need this one also to reland ...

13 years, 3 months ago (2011-08-03 14:19:10 UTC) #2

bsalomon

13 years, 3 months ago (2011-08-03 14:35:29 UTC) #3

Closed with r2034.

On 2011/08/03 14:19:10, TomH wrote:
> I presume it'll actually get called from a different patch.

Yup, new version of r2026 going up in a moment that uses this.

Expand All Messages | Collapse All Messages