Issue 4839050: Fail path rendering gracefully when vb/ib space alloc fails

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4839050: Fail path rendering gracefully when vb/ib space alloc fails (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bsalomon

Modified:
13 years, 3 months ago

Reviewers:
Stephen White, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : better #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	gpu/src/GrPathRenderer.cpp	View	1 2	4 chunks	+17 lines, -5 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Stephen White

LGTM http://codereview.appspot.com/4839050/diff/3001/gpu/src/GrPathRenderer.cpp File gpu/src/GrPathRenderer.cpp (right): http://codereview.appspot.com/4839050/diff/3001/gpu/src/GrPathRenderer.cpp#newcode403 gpu/src/GrPathRenderer.cpp:403: // set these at the so if we ...

13 years, 3 months ago (2011-08-05 15:55:09 UTC) #3

Closed with r2052

Expand All Messages | Collapse All Messages