Small miter limit check on Gr::drawRect.

[bsalomon, 2011-08-09 18:09:12]

LGTM

On Tue, Aug 9, 2011 at 2:00 PM, <bungeman@google.com> wrote:

> Reviewers: bsalomon,
>
>
>
> Please review this at
http://codereview.appspot.com/**4838057/<http://codereview.appspot.com/4838057/>
>
> Affected files:
>  M     src/gpu/SkGpuDevice.cpp
>
>
> Index: src/gpu/SkGpuDevice.cpp
> ==============================**==============================**=======
> --- src/gpu/SkGpuDevice.cpp     (revision 2063)
> +++ src/gpu/SkGpuDevice.cpp     (working copy)
> @@ -760,8 +760,12 @@
>     if (!usePath && paint.isAntiAlias() && !draw.fMatrix->rectStaysRect()*
> *) {
>         usePath = true;
>     }
> +    // small miter limits mean clipped edges...
> +    if (SkPaint::kMiter_Join == paint.getStrokeJoin() &&
> +        paint.getStrokeMiter() < SK_ScalarSqrt2) {
> +        usePath = true;
> +    }
>     // until we can both stroke and fill rectangles
> -    // with large enough miter limit...
>     if (paint.getStyle() == SkPaint::kStrokeAndFill_Style) {
>         usePath = true;
>     }
>
>
>

[reed1, 2011-08-09 18:15:51]

Not sure what your comment means about clipping. Do you mean, we don't correctly
handle the smaller miters (which I agree)?

[bungeman, 2011-08-09 18:33:39]

Committed revision 2086.