Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4141)

Issue 4837074: Ajax delete of multiple items has been implemented at index page

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by sinha
Modified:
13 years, 3 months ago
Visibility:
Public.

Description

This feature still need some modification, but this is the baisc working version of it. And it is working for unicode itemnames (tried it for chinese and russian names).

Patch Set 1 #

Total comments: 4

Patch Set 2 : ajax delete feature code modified, now data passed/retrieved as json #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -4 lines) Patch
M MoinMoin/apps/frontend/views.py View 1 2 chunks +35 lines, -0 lines 2 comments Download
M MoinMoin/static/js/index_action.js View 1 3 chunks +82 lines, -2 lines 2 comments Download
M MoinMoin/templates/index.html View 3 chunks +13 lines, -2 lines 0 comments Download
M MoinMoin/themes/modernized/static/css/common.css View 1 chunk +8 lines, -0 lines 0 comments Download
A MoinMoin/themes/modernized/static/img/moin-transparent-bg.png View Binary file 0 comments Download

Messages

Total messages: 3
Reimar Bauer
some comments, repeated some parts thomas told already http://codereview.appspot.com/4837074/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/4837074/diff/1/MoinMoin/apps/frontend/views.py#newcode429 MoinMoin/apps/frontend/views.py:429: itemnames ...
13 years, 3 months ago (2011-08-10 19:50:11 UTC) #1
sinha
now, json is implemented in itemnames passing and status of all items are being returned, ...
13 years, 3 months ago (2011-08-11 18:47:42 UTC) #2
Reimar Bauer
13 years, 3 months ago (2011-08-11 20:28:33 UTC) #3
>now, json is implemented in itemnames passing and status of
>all items are being
>returned, just need some suggestion on how to show the >deletion status of each
>item on the page.

the deleted ones can be grayed out, removed, or the link can be removed, or they
get a trash icon prefix, somthing like that

http://codereview.appspot.com/4837074/diff/5001/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4837074/diff/5001/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:38: import json
indenting

http://codereview.appspot.com/4837074/diff/5001/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:438: print itemname
better use logging, not print because if a print is leftover the server can
crash

http://codereview.appspot.com/4837074/diff/5001/MoinMoin/static/js/index_acti...
File MoinMoin/static/js/index_action.js (right):

http://codereview.appspot.com/4837074/diff/5001/MoinMoin/static/js/index_acti...
MoinMoin/static/js/index_action.js:30: var itemnames =JSON.stringify(links);
missing blank

http://codereview.appspot.com/4837074/diff/5001/MoinMoin/static/js/index_acti...
MoinMoin/static/js/index_action.js:40: var delete_status= data.status;
missing blank
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b