Issue 4837059: Bail draws on VB failures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4837059: Bail draws on VB failures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by bsalomon

Modified:
14 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -8 lines)			Patch
M	gpu/include/GrContext_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrBufferAllocPool.cpp	View	1 2 3 4	1 chunk	+6 lines, -1 line	0 comments	Download
M	gpu/src/GrContext.cpp	View	1 2 3	7 chunks	+24 lines, -6 lines	0 comments	Download
M	gpu/src/GrDrawTarget.cpp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/src/GrInOrderDrawBuffer.cpp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2

bsalomon

Bail on draws when we can't get our verts/idxs into buffers. Also, noticed a subtle ...

14 years ago (2011-08-05 20:00:40 UTC) #1

bsalomon

14 years ago (2011-08-05 20:14:10 UTC) #2

Closed with r2053. Includes discussed additional asserts in AutoReleaseGeometry.
 (Got verbal lgtm from Mike)