Add GrStencilBuffer as a separate resource type from render target

[bsalomon, 2011-08-01 21:30:18]

With this change we'll be very close to sharing stencil buffers between render
targets via the cache.

[reed1, 2011-08-01 21:47:54]

Hell, you keep reducing our public API footprint, so I'm happy. LGTM

[TomH, 2011-08-02 13:26:06]

LGTM

http://codereview.appspot.com/4837046/diff/2002/gpu/src/GrGpu.cpp
File gpu/src/GrGpu.cpp (right):

http://codereview.appspot.com/4837046/diff/2002/gpu/src/GrGpu.cpp#newcode148
gpu/src/GrGpu.cpp:148: // TODO: defer this and attach dynamically
I assume the several TODOs here are to be done in one of the subsequent patches.

http://codereview.appspot.com/4837046/diff/2002/gpu/src/GrGpuGL.cpp
File gpu/src/GrGpuGL.cpp (right):

http://codereview.appspot.com/4837046/diff/2002/gpu/src/GrGpuGL.cpp#newcode1107
gpu/src/GrGpuGL.cpp:1107: // If we are using multisampling and we will create
two FBOS We render
Misplaced "and"?

[bsalomon, 2011-08-02 14:12:07]

Closed with r2026.

On 2011/08/02 13:26:06, TomH wrote:
http://codereview.appspot.com/4837046/diff/2002/gpu/src/GrGpu.cpp#newcode148
> gpu/src/GrGpu.cpp:148: // TODO: defer this and attach dynamically
> I assume the several TODOs here are to be done in one of the subsequent
patches.

Yes, those patches haven't been written yet. With this one all my local changes
related to this are in.

>http://codereview.appspot.com/4837046/diff/2002/gpu/src/GrGpuGL.cpp#newcode1107
> gpu/src/GrGpuGL.cpp:1107: // If we are using multisampling and we will create
> two FBOS We render
> Misplaced "and"?

Fixed it before checking in.

[bsalomon, 2011-08-03 14:51:43]

Reverted and reopened because of GM mac/linux assertions.

New patch addresses them. Changes from previously checked in patch are all in
this diff:
http://codereview.appspot.com/4837046/diff2/2002:3012/gpu/src/GrGpuGL.cpp

[TomH, 2011-08-03 15:03:16]

Still LGTM.

[TomH, 2011-08-03 15:03:29]

On 2011/08/03 15:03:16, TomH wrote:
> Still LGTM.

And thanks for the comments, by the way.

[bsalomon, 2011-08-03 15:36:32]

Closed with r2035.