Issue 4832046: Prevents lilypond from segfaulting with add-footer = ##f

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4832046: Prevents lilypond from segfaulting with add-footer = ##f (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by MikeSol

Modified:
12 years, 8 months ago

Reviewers:
pkx166h, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Prevents lilypond from segfaulting with add-footer = ##f

Patch Set 2 : Complete fix (I think). #

Total comments: 1

Patch Set 3 : Only issues warning if user uses footnotes with no footer. #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	lily/page-breaking.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	lily/page-layout-problem.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Neil Puttock

http://codereview.appspot.com/4832046/diff/2001/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): http://codereview.appspot.com/4832046/diff/2001/lily/page-layout-problem.cc#newcode282 lily/page-layout-problem.cc:282: warning ("Must have a footer to add footnotes."); (_ ...

12 years, 8 months ago (2011-08-02 21:45:52 UTC) #3

MikeSol

On 2011/08/02 21:45:52, Neil Puttock wrote: > http://codereview.appspot.com/4832046/diff/2001/lily/page-layout-problem.cc > File lily/page-layout-problem.cc (right): > > http://codereview.appspot.com/4832046/diff/2001/lily/page-layout-problem.cc#newcode282 ...

12 years, 8 months ago (2011-08-09 06:47:11 UTC) #4

Neil Puttock

12 years, 8 months ago (2011-08-09 17:27:43 UTC) #5

On 2011/08/09 06:47:11, MikeSol wrote:

> Fix pushed as 435b36a3e6576cebf794d815ae7cc78b652180f9.

The warning message still needs tweaking:

warning (_ ("must have a footer to add footnotes"))

Expand All Messages | Collapse All Messages