Issue 4832043: updated file upload js script, now only unique files could be uploaded during a upload

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4832043: updated file upload js script, now only unique files could be uploaded during a upload

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by sinha

Modified:
13 years, 3 months ago

Reviewers:
Reimar Bauer

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	MoinMoin/static/js/jfu.js	View		5 chunks	+14 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Reimar Bauer

13 years, 3 months ago (2011-08-01 09:32:03 UTC) #1

besides pep8 empty lines with blanks

it sounds ok for me

http://codereview.appspot.com/4832043/diff/1/MoinMoin/static/js/jfu.js
File MoinMoin/static/js/jfu.js (right):

http://codereview.appspot.com/4832043/diff/1/MoinMoin/static/js/jfu.js#newcode76
MoinMoin/static/js/jfu.js:76: 
pep8 blanks

not empty lines with blanks

Expand All Messages | Collapse All Messages