Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1247)

Issue 4830050: Beginnings of a new preprocessor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by Alok Priyadarshi
Modified:
12 years, 9 months ago
Reviewers:
kbr1, dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Beginnings of a new preprocessor. Committed: http://code.google.com/p/angleproject/source/detail?r=718

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5370 lines, -0 lines) Patch
A src/compiler/preprocessor/new/Context.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Context.cpp View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Input.h View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Input.cpp View 1 2 1 chunk +165 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Macro.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Preprocessor.h View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Preprocessor.cpp View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Token.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Token.cpp View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/generate_parser.sh View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/pp.l View 1 2 1 chunk +153 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/pp.y View 1 2 1 chunk +242 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/pp_lex.cpp View 1 2 1 chunk +2252 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/pp_tab.h View 1 2 1 chunk +120 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/pp_tab.cpp View 1 2 1 chunk +2084 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Alok Priyadarshi
I realized that I can do step 1 (removing comments) while reading the input. This ...
12 years, 9 months ago (2011-08-01 22:32:28 UTC) #1
kbr1
LGTM. Good to see continued progress on replacing the preprocessor. A suggestion regarding file placement: ...
12 years, 9 months ago (2011-08-02 22:43:24 UTC) #2
dgkoch
On 2011/08/02 22:43:24, kbr1 wrote: > LGTM. Good to see continued progress on replacing the ...
12 years, 9 months ago (2011-08-05 04:59:05 UTC) #3
Alok Priyadarshi
12 years, 9 months ago (2011-08-07 05:37:23 UTC) #4
Moved to preprocessor/new and committed as r718.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b