I realized that I can do step 1 (removing comments) while reading the input. This ...
12 years, 9 months ago
(2011-08-01 22:32:28 UTC)
#1
I realized that I can do step 1 (removing comments) while reading the input.
This makes it much simpler and avoids copying the string twice.
Made changes to adhere to ANGLE style guide.
Daniel: I have not moved the files out of the preprocessor folder. If we just
deleted all the old files and LICENSE.preprocessor once we are ready to switch,
it would not be enough? Do you have a naming suggestion for the new folder in
case you still think it is a good idea.
LGTM. Good to see continued progress on replacing the preprocessor. A suggestion regarding file placement: ...
12 years, 9 months ago
(2011-08-02 22:43:24 UTC)
#2
LGTM. Good to see continued progress on replacing the preprocessor.
A suggestion regarding file placement: make a subdirectory under
src/compiler/preprocessor called "new" and put the new files there. When the new
preprocessor is done, delete the old files and move everything in "new" one
directory up.
On 2011/08/02 22:43:24, kbr1 wrote: > LGTM. Good to see continued progress on replacing the ...
12 years, 9 months ago
(2011-08-05 04:59:05 UTC)
#3
On 2011/08/02 22:43:24, kbr1 wrote:
> LGTM. Good to see continued progress on replacing the preprocessor.
>
> A suggestion regarding file placement: make a subdirectory under
> src/compiler/preprocessor called "new" and put the new files there. When the
new
> preprocessor is done, delete the old files and move everything in "new" one
> directory up.
LGTM other than location. I'm fine with kbr's suggestion to put in a subfolder.
Alternatively I'd recommend an adjacent folder called 'preproc' or something
like that, might save you having to move it at the end.
Issue 4830050: Beginnings of a new preprocessor.
(Closed)
Created 12 years, 9 months ago by Alok Priyadarshi
Modified 12 years, 9 months ago
Reviewers: kbr1, dgkoch, nicolas
Base URL: http://angleproject.googlecode.com/svn/trunk/
Comments: 0