Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1985)

Issue 4828050: Remove unnecessary dirty clip flag in GrGpu, remove getUsableStencilBits() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by bsalomon
Modified:
13 years, 3 months ago
Reviewers:
TomH, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

getUsableStencilBits() isn't being called anywhere. It will problematic when stencil buffers aren't statically bound to render targets but are bound lazily when needed. If some code path really needs this we'll have to figure out a new semantic for allowing the client to bind a SB before drawing and release it afterwards.

Patch Set 1 #

Patch Set 2 : line break cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -58 lines) Patch
M gpu/include/GrDrawTarget.h View 2 chunks +3 lines, -19 lines 0 comments Download
M gpu/include/GrGpu.h View 1 chunk +3 lines, -10 lines 0 comments Download
M gpu/include/GrStencil.h View 1 1 chunk +5 lines, -7 lines 0 comments Download
M gpu/src/GrGpu.cpp View 1 3 chunks +9 lines, -18 lines 0 comments Download
M gpu/src/GrGpuGL.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M gpu/src/GrInOrderDrawBuffer.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
bsalomon
13 years, 3 months ago (2011-08-01 15:03:11 UTC) #1
reed1
SWE -- sure, whatever
13 years, 3 months ago (2011-08-01 15:25:13 UTC) #2
bsalomon
13 years, 3 months ago (2011-08-01 16:53:13 UTC) #3
Closed with the timely r2011.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b