Issue 4827043: Properly handle parallel make ("make -j"), and only rerun gyp if necessary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4827043: Properly handle parallel make ("make -j"), and only rerun gyp if necessary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by epoger

Modified:
13 years, 4 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com, vandebo (use chromium instead)

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Properly handle parallel make ("make -j"), and only rerun gyp if necessary. This should completely resolve http://code.google.com/p/skia/issues/detail?id=330 ('building multiple targets in parallel fails on Linux') This should resolve http://code.google.com/p/skia/issues/detail?id=313 ('toplevel makefile always reruns gyp_skia') for Linux, but not Mac. (See details in comments within the file) Committed: http://code.google.com/p/skia/source/detail?r=1968

Patch Set 1 #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -23 lines)			Patch
	M	Makefile	View		2 chunks	+39 lines, -23 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

13 years, 4 months ago (2011-07-27 13:57:51 UTC) #3

LGTM, but the mac bug doesn't bite me. Let's make sure fixing that is on your
schedule.

http://codereview.appspot.com/4827043/diff/1/Makefile
File Makefile (right):

http://codereview.appspot.com/4827043/diff/1/Makefile#newcode43
Makefile:43: .NOTPARALLEL:
Awesome.

Expand All Messages | Collapse All Messages