Issue 4826057: Base setting should be honoured

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4826057: Base setting should be honoured (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by ade

Modified:
12 years, 11 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 2 : Changed code to use datafile() function #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	tests/test_discovery.py	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jcgregorio_google

http://codereview.appspot.com/4826057/diff/1/tests/test_discovery.py File tests/test_discovery.py (right): http://codereview.appspot.com/4826057/diff/1/tests/test_discovery.py#newcode70 tests/test_discovery.py:70: discovery = file(os.path.join(os.path.dirname(__file__), "data/buzz.json"), "r").read() Use the 'datafile' method ...

13 years ago (2011-08-18 19:30:25 UTC) #1

LGTM

Expand All Messages | Collapse All Messages