Upload functionality added at item index page

[sinha, 2011-07-22 15:38:12]

Please also see the diary page
(http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-07-22) for the view.

http://codereview.appspot.com/4820042/diff/1/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4820042/diff/1/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:463: return jsonify(files=files)
I dont think i need this section now, (this whole GET request).

[Reimar Bauer, 2011-07-22 17:12:25]

some comments

http://codereview.appspot.com/4820042/diff/1/MoinMoin/static/js/jfu.js
File MoinMoin/static/js/jfu.js (right):

http://codereview.appspot.com/4820042/diff/1/MoinMoin/static/js/jfu.js#newcod...
MoinMoin/static/js/jfu.js:281: // No need to do at index now
the comments also not needed

http://codereview.appspot.com/4820042/diff/1/MoinMoin/templates/index.html
File MoinMoin/templates/index.html (right):

http://codereview.appspot.com/4820042/diff/1/MoinMoin/templates/index.html#ne...
MoinMoin/templates/index.html:41: <div id="file_upload">
please move the file uploader to forms.html

It can be used then also somewhere else.

http://codereview.appspot.com/4820042/diff/1/MoinMoin/templates/index.html#ne...
MoinMoin/templates/index.html:49: <button class="file_upload_start"
style="display:none;">Start All</button>
i18n for all buttons

http://codereview.appspot.com/4820042/diff/1/MoinMoin/templates/index.html#ne...
MoinMoin/templates/index.html:62: <h2 style="display: none;">{{ _("More Index")
}}</h2>
name this "Recently uploaded Items" 

and move it on top of the existing index, then it automaticly gets in focus by
the user

[Reimar Bauer, 2011-07-22 17:12:57]

some comments

[Reimar Bauer, 2011-07-22 17:21:54]

extended comment for recent uploads

http://codereview.appspot.com/4820042/diff/1/MoinMoin/templates/index.html
File MoinMoin/templates/index.html (right):

http://codereview.appspot.com/4820042/diff/1/MoinMoin/templates/index.html#ne...
MoinMoin/templates/index.html:62: <h2 style="display: none;">{{ _("More Index")
}}</h2>
name this "Recently uploaded Items" 

and move it on top of the existing index, 
below "Index of ..."
then it automaticly gets in focus by the user

[sinha, 2011-07-23 22:06:41]

Code Modified.

http://codereview.appspot.com/4820042/diff/7/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4820042/diff/7/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:453: if request.method == 'GET':
should i remove this complete GET response, as i have removed the get ajax call
from js file, if yes then what should i return on GET here(403 Error ?).

(OR we can leave this as it as, and may use it later at someplace).

[Reimar Bauer, 2011-07-24 08:11:14]

look at route decorator and change it their also to POST
If you don't set a method default is GET (http://flask.pocoo.org/docs/api/)

If we want that the jfu script only can be called with POST we should verify
that it can't be used by GET

http://codereview.appspot.com/4820042/diff/7/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/4820042/diff/7/MoinMoin/apps/frontend/views.py#...
MoinMoin/apps/frontend/views.py:453: if request.method == 'GET':
On 2011/07/23 22:06:42, sinha wrote:
> should i remove this complete GET response, as i have removed the get ajax
call
> from js file, if yes then what should i return on GET here(403 Error ?).
> 
> (OR we can leave this as it as, and may use it later at someplace).

Remove it, we still have it in the repository.

And change the @frontend.route so that it only is POST

Then you don't need an abort for GET

http://codereview.appspot.com/4820042/diff/7/MoinMoin/static/js/jfu.js
File MoinMoin/static/js/jfu.js (right):

http://codereview.appspot.com/4820042/diff/7/MoinMoin/static/js/jfu.js#newcode10
MoinMoin/static/js/jfu.js:10: */
Please make sure that the script only can be called with POST