Issue 4819069: Fix the timeout mechanism for launching the chrome instance on Windows pre-7.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4819069: Fix the timeout mechanism for launching the chrome instance on Windows pre-7. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by Roger McFarlane

Modified:
12 years, 8 months ago

Reviewers:
ericdingle, chrisha, Siggi

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix the timeout mechanism for launching the chrome instance on Windows pre-7. Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk395

Patch Set 2 : '' #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -13 lines)			Patch
M	syzygy/scripts/benchmark/chrome_control.py	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download
M	syzygy/scripts/benchmark/optimize.py	View		5 chunks	+11 lines, -3 lines	0 comments	Download
M	syzygy/scripts/benchmark/runner.py	View	1	5 chunks	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Siggi

lgtm - nice! http://codereview.appspot.com/4819069/diff/1/syzygy/scripts/benchmark/runner.py File syzygy/scripts/benchmark/runner.py (right): http://codereview.appspot.com/4819069/diff/1/syzygy/scripts/benchmark/runner.py#newcode246 syzygy/scripts/benchmark/runner.py:246: RunnerError if Chrome is not running ...

12 years, 8 months ago (2011-08-10 15:14:54 UTC) #2

Roger McFarlane

12 years, 8 months ago (2011-08-10 15:18:09 UTC) #3

Thanks.

Committed.

http://codereview.appspot.com/4819069/diff/1/syzygy/scripts/benchmark/runner.py
File syzygy/scripts/benchmark/runner.py (right):

http://codereview.appspot.com/4819069/diff/1/syzygy/scripts/benchmark/runner....
syzygy/scripts/benchmark/runner.py:246: RunnerError if Chrome is not running
after a 20 second wait.
On 2011/08/10 15:14:54, Siggi wrote:
> nit: update 20 seconds to 5 minutes.

Done.

Expand All Messages | Collapse All Messages