Issue 4817047: Generate more useful messages for out-of-line definition errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4817047: Generate more useful messages for out-of-line definition errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Kaelyn

Modified:
13 years, 4 months ago

Reviewers:

Visibility:
Public.

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -10 lines)			Patch
M	include/clang/AST/Type.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	include/clang/Basic/DiagnosticSemaKinds.td	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/AST/Type.cpp	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
M	lib/Sema/SemaDecl.cpp	View	1 2	2 chunks	+43 lines, -8 lines	0 comments	Download
M	test/SemaCXX/nested-name-spec.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A	test/SemaCXX/out-of-line-def-mismatch.cpp	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 1

Kaelyn

13 years, 4 months ago (2011-08-04 17:42:18 UTC) #1

Committed as revision 136891, with a few small changes to the new note text in
DiagnosticSemaKinds.td for consistency.