Issue 4816055: Make shadow stack use exception resistant.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4816055: Make shadow stack use exception resistant. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by Siggi

Modified:
12 years, 8 months ago

Reviewers:
chrisha

CC:
sawbuck-changes_googlegroups.com

Base URL:
https://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

Description

Make shadow stack use exception resistant. Tests for same. R=chrisha@chromium.org BUG=None TEST=None Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk387

Patch Set 1 #

Patch Set 2 : Fix release breakage due to stomping on volatile registers. Fix unittest conditions. #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -16 lines)			Patch
M	syzygy/call_trace/call_trace_dll_unittest.cc	View	1	2 chunks	+117 lines, -1 line	0 comments	Download
M	syzygy/call_trace/call_trace_main.h	View		4 chunks	+14 lines, -3 lines	0 comments	Download
M	syzygy/call_trace/call_trace_main.cc	View		6 chunks	+94 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Siggi

Fixed Release test breakage due to not saving the right set of registers. Also fixed ...

12 years, 8 months ago (2011-07-27 16:02:43 UTC) #3

Siggi

12 years, 8 months ago (2011-07-27 16:29:42 UTC) #5

Thanks, committing.

On Wed, Jul 27, 2011 at 4:26 PM, <chrisha@chromium.org> wrote:

> lgtm
>
>
>
http://codereview.appspot.com/**4816055/<http://codereview.appspot.com/4816055/>
>

Expand All Messages | Collapse All Messages