Issue 4816051: [PDF] Fix bug in catalog substitution.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4816051: [PDF] Fix bug in catalog substitution. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Steve VanDeBogart

Modified:
12 years, 11 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com, arthurhsu

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Fix bug in catalog substitution. Committed: http://code.google.com/p/skia/source/detail?r=1955

Patch Set 2 : Address comment #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/pdf/SkPDFCatalog.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/PDFPrimitivesTest.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Chris Guillory

LGTM http://codereview.appspot.com/4816051/diff/1/src/pdf/SkPDFCatalog.cpp File src/pdf/SkPDFCatalog.cpp (right): http://codereview.appspot.com/4816051/diff/1/src/pdf/SkPDFCatalog.cpp#newcode53 src/pdf/SkPDFCatalog.cpp:53: SkPDFObject* realObj = getSubstituteObject(obj); Optional: Remove the realObj ...

12 years, 11 months ago (2011-07-25 22:17:42 UTC) #1

Steve VanDeBogart

12 years, 11 months ago (2011-07-25 22:22:13 UTC) #2

http://codereview.appspot.com/4816051/diff/1/src/pdf/SkPDFCatalog.cpp
File src/pdf/SkPDFCatalog.cpp (right):

http://codereview.appspot.com/4816051/diff/1/src/pdf/SkPDFCatalog.cpp#newcode53
src/pdf/SkPDFCatalog.cpp:53: SkPDFObject* realObj = getSubstituteObject(obj);
On 2011/07/25 22:17:42, Chris Guillory wrote:
> Optional: Remove the realObj local?

Done.

Expand All Messages | Collapse All Messages