Turn GrTextureCache into GrResourceCache

Make the GrTextureCache a generic GrResourceCache (so it can manage stencil buffers in the future). Also, do some cleanup on the GrContext texture interface.

[Stephen White, 2011-07-25 20:58:29]

Great improvement over than silly unlock-only guard, thanks.

http://codereview.appspot.com/4815055/diff/5001/gpu/include/GrContext.h
File gpu/include/GrContext.h (right):

http://codereview.appspot.com/4815055/diff/5001/gpu/include/GrContext.h#newco...
gpu/include/GrContext.h:727: GrContext::ScratchTexMatch match)
Perhaps the last param could have a default arg (preferably
kApprox_ScratchTexMatch, since that seems to be the most common).  Seems like
that would make a lot of call sites shorter.

http://codereview.appspot.com/4815055/diff/5001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (left):

http://codereview.appspot.com/4815055/diff/5001/src/gpu/SkGpuDevice.cpp#oldco...
src/gpu/SkGpuDevice.cpp:944: // Stash away a copy of the unblurred image.
I can haz comment back?  ^,,^

[bsalomon, 2011-07-26 13:04:51]

On 2011/07/25 20:58:29, Stephen White wrote:
>
http://codereview.appspot.com/4815055/diff/5001/gpu/include/GrContext.h#newco...
> gpu/include/GrContext.h:727: GrContext::ScratchTexMatch match)
> Perhaps the last param could have a default arg (preferably
> kApprox_ScratchTexMatch, since that seems to be the most common).  Seems like
> that would make a lot of call sites shorter.

Good idea, done in latest patch.

>
http://codereview.appspot.com/4815055/diff/5001/src/gpu/SkGpuDevice.cpp#oldco...
> src/gpu/SkGpuDevice.cpp:944: // Stash away a copy of the unblurred image.
> I can haz comment back?  ^,,^

oops! :) Comment is restored.

[Stephen White, 2011-07-26 19:54:30]

LGTM

[bsalomon, 2011-07-28 21:40:39]

Closed with r1965