Issue 4814063: Remove unnecessary Visit function overloading.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4814063: Remove unnecessary Visit function overloading. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by Zhenyao Mo

Modified:
14 years, 8 months ago

Reviewers:
nicolas

CC:
angleproject-review_googlegroups.com, kbr1, Alok Priyadarshi

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Remove unnecessary Visit function overloading. BUG=none TEST=build ok, run as before Committed: http://code.google.com/p/angleproject/source/detail?r=715

Patch Set 1 #

Patch Set 2 : '' #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -112 lines)			Patch
M	src/common/version.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/DetectRecursion.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/compiler/DetectRecursion.cpp	View	1	2 chunks	+0 lines, -33 lines	0 comments	Download
M	src/compiler/MapLongVariableNames.h	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/compiler/MapLongVariableNames.cpp	View	1	2 chunks	+0 lines, -29 lines	0 comments	Download
M	src/compiler/ValidateLimitations.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/compiler/ValidateLimitations.cpp	View	1	5 chunks	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Zhenyao Mo

On 2011/08/01 21:43:10, Zhenyao Mo wrote: > Please review. Nicolas: ping.

14 years, 8 months ago (2011-08-02 21:55:46 UTC) #2

Looking good.

Expand All Messages | Collapse All Messages