Issue 4813050: modified contenttype filtering to handle contenttypes without the encoding and the unknown cases.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4813050: modified contenttype filtering to handle contenttypes without the encoding and the unknown cases.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by sinha

Modified:
13 years, 5 months ago

Reviewers:
Reimar Bauer

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -9 lines)			Patch
	M	MoinMoin/items/__init__.py	View		2 chunks	+24 lines, -9 lines	3 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Reimar Bauer

besides the comments, ok http://codereview.appspot.com/4813050/diff/1/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/4813050/diff/1/MoinMoin/items/__init__.py#newcode612 MoinMoin/items/__init__.py:612: # If a item's contenttype ...

13 years, 5 months ago (2011-07-26 06:10:41 UTC) #1

sinha

13 years, 5 months ago (2011-07-26 19:00:12 UTC) #2

replied to comment.

http://codereview.appspot.com/4813050/diff/1/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

http://codereview.appspot.com/4813050/diff/1/MoinMoin/items/__init__.py#newco...
MoinMoin/items/__init__.py:612: # If a item's contenttype not present in the
default contenttype list,
On 2011/07/26 06:10:41, Reimar Bauer wrote:
> apostrophe "'s" means "is" so that is wrong here.
> 
> some famous failures
> http://www.apostrophecatastrophes.com/
> 
> s/a/an/

But i guess apostrophe before the s is placed to show the possession. If you
think it is still wrong then, would this sentence also be wrong: "This is
Bauer's house" ?
http://www.grammarbook.com/punctuation/apostro.asp

Expand All Messages | Collapse All Messages