Issue 4811049: [PDF] Refactor SkPDFFont to enable font/cmap subsetting.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4811049: [PDF] Refactor SkPDFFont to enable font/cmap subsetting. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Steve VanDeBogart

Modified:
12 years, 9 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Refactor SkPDFFont to enable font/cmap subsetting. Patch from Arthur Hsu, original CL: http://codereview.appspot.com/4633050/ Committed: http://code.google.com/p/skia/source/detail?r=1943 Reverted: http://code.google.com/p/skia/source/detail?r=1944 Committed: http://code.google.com/p/skia/source/detail?r=1956

Patch Set 1 #

Patch Set 2 : nits #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+784 lines, -355 lines)			Patch
M	gyp/pdf.gyp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	include/pdf/SkBitSet.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	include/pdf/SkPDFDevice.h	View		3 chunks	+15 lines, -4 lines	0 comments	Download
M	include/pdf/SkPDFDocument.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/pdf/SkPDFFont.h	View		4 chunks	+114 lines, -58 lines	0 comments	Download
M	include/pdf/SkPDFPage.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pdf/SkBitSet.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View		8 chunks	+23 lines, -8 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	1	4 chunks	+28 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	1	16 chunks	+497 lines, -279 lines	0 comments	Download
A	src/pdf/SkPDFFontImpl.h	View		1 chunk	+90 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download