Fix crash in GrStencilBuffer at context teardown

[bsalomon, 2011-08-09 17:48:37]

Fixes DRT for skia roll.

[reed1, 2011-08-09 17:52:29]

LGTM

Another pattern to ensure that the base-class version is also called is:

void baseclass::release() {
    this->onRelease();  // subclass
    ... base class release code
}

[bsalomon, 2011-08-09 17:55:10]

Yeah in this case it'd have to be two levels of that pattern.

GrResource already has release which calls subclass's onRelease.

Now I want GrGLStencilBuffer to call GrStencilBuffer's onRelease, so I'd
need an onOnRelease :)


On Tue, Aug 9, 2011 at 1:52 PM, <reed@google.com> wrote:

> LGTM
>
> Another pattern to ensure that the base-class version is also called is:
>
> void baseclass::release() {
>    this->onRelease();  // subclass
>    ... base class release code
>
> }
>
>
http://codereview.appspot.com/**4810088/<http://codereview.appspot.com/4810088/>
>

[reed1, 2011-08-09 17:58:03]

doh!

On Tue, Aug 9, 2011 at 10:54 AM, Brian Salomon <bsalomon@google.com> wrote:
> Yeah in this case it'd have to be two levels of that pattern.
> GrResource already has release which calls subclass's onRelease.
> Now I want GrGLStencilBuffer to call GrStencilBuffer's onRelease, so I'd
> need an onOnRelease :)
>
> On Tue, Aug 9, 2011 at 1:52 PM, <reed@google.com> wrote:
>>
>> LGTM
>>
>> Another pattern to ensure that the base-class version is also called is:
>>
>> void baseclass::release() {
>>    this->onRelease();  // subclass
>>    ... base class release code
>> }
>>
>> http://codereview.appspot.com/4810088/
>
>

[bsalomon, 2011-08-10 12:12:52]

Closed with r2084.