Issue 4810084: Making Cocoa and Carbon Coexist

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4810084: Making Cocoa and Carbon Coexist (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by yangsu

Modified:
12 years, 10 months ago

Reviewers:
epoger, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -106 lines)			Patch
D	experimental/CocoaSampleApp/SkOSWindow_Mac.h	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	experimental/CocoaSampleApp/SkOSWindow_Mac.mm	View	1 chunk	+0 lines, -66 lines	0 comments	Download
M	gyp/CocoaSampleApp.gyp	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	gyp/SampleApp.gyp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	include/views/SkWindow.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	src/utils/mac/SkOSWindow_Mac_Cocoa.mm	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

yangsu

Changes: - added conditional to SkWindow.h include SkOSWindow_Mac_Cocoa.h - define SK_MAC_COCOA in CocoaSampleApp - added ...

12 years, 10 months ago (2011-08-08 18:31:17 UTC) #1

LGTM