Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(388)

Issue 4810068: Download(Multiple) feature for index items, added on index page

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by sinha
Modified:
13 years, 4 months ago
Reviewers:
Reimar Bauer
Visibility:
Public.

Description

There is some issues posted on diary page http://moinmo.in/AkashSinha/Gsoc2011Diary/2011-08-05

Patch Set 1 #

Total comments: 2

Patch Set 2 : download feature added on items of index page #

Patch Set 3 : mimetype parameter added in download link for the files being downloaded #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M MoinMoin/apps/frontend/views.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M MoinMoin/items/__init__.py View 1 2 5 chunks +15 lines, -9 lines 0 comments Download
M MoinMoin/templates/index.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1
Reimar Bauer
13 years, 4 months ago (2011-08-03 20:46:50 UTC) #1
some comments.

for download please use
http://pypi.python.org/pypi/XStatic-multiDownload/20110717.1

http://codereview.appspot.com/4810068/diff/1/MoinMoin/static/js/index_action.js
File MoinMoin/static/js/index_action.js (right):

http://codereview.appspot.com/4810068/diff/1/MoinMoin/static/js/index_action....
MoinMoin/static/js/index_action.js:3: $(".moin-select-item").live("click",
function (){
about the icons, to which lib do they belong.

http://codereview.appspot.com/4810068/diff/1/MoinMoin/templates/index.html
File MoinMoin/templates/index.html (right):

http://codereview.appspot.com/4810068/diff/1/MoinMoin/templates/index.html#ne...
MoinMoin/templates/index.html:44: <span class="moin-select-allitem
allitem-toselect" title="{{ _("Select All") }}">&nbsp;</span>
i can't see _("Select All") in my version, not sure currently if this is a
problem on my site.

In gnereal it would be good this becomes combined with Filter by Content Type
and Index Letter subset
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b