Add an option to support for GL_OES_EGL_image_external.

Add an option to support for GL_OES_EGL_image_external.

Comes with this extension is the new sampler type samplerExternalOES.

ANGLEBUG=175
TEST=compile the attached shader file

[Zhenyao Mo, 2011-08-05 18:14:27]

Please review.

[dgkoch, 2011-08-08 15:57:23]

Nothing too obvious jumping out at me.  

What are your plans for this?  Is this something you'll implement on the
API-side as well or is this more just for the validator and ESSL-backend at this
point?

Note that Alok also has outstanding approved compiler changes so make sure you
coordinate checkin with him.

http://codereview.appspot.com/4809076/diff/3015/src/common/version.h
File src/common/version.h (right):

http://codereview.appspot.com/4809076/diff/3015/src/common/version.h#newcode4
src/common/version.h:4: #define BUILD_REVISION 716
beware of conflicts here, but due update this.

http://codereview.appspot.com/4809076/diff/3015/src/compiler/Initialize.cpp
File src/compiler/Initialize.cpp (right):

http://codereview.appspot.com/4809076/diff/3015/src/compiler/Initialize.cpp#n...
src/compiler/Initialize.cpp:642: extBehavior["GL_OES_EGL_image_external"] =
EBhUndefined;
Extensions are supposed to be disabled unless they are explicitly enabled.  Does
this change that?

[kbr1, 2011-08-08 22:04:13]

LGTM

http://codereview.appspot.com/4809076/diff/3015/samples/translator/translator...
File samples/translator/translator.cpp (right):

http://codereview.appspot.com/4809076/diff/3015/samples/translator/translator...
samples/translator/translator.cpp:179: printf("Usage: translate [-i -m -o -u
-b=e -b=g -b=h] file1 file2 ...\n"
Needs updating.

http://codereview.appspot.com/4809076/diff/3015/src/compiler/Initialize.cpp
File src/compiler/Initialize.cpp (right):

http://codereview.appspot.com/4809076/diff/3015/src/compiler/Initialize.cpp#n...
src/compiler/Initialize.cpp:642: extBehavior["GL_OES_EGL_image_external"] =
EBhUndefined;
On 2011/08/08 15:57:30, dgkoch wrote:
> Extensions are supposed to be disabled unless they are explicitly enabled. 
Does
> this change that?

It looks like Mo's changed the implementation to avoid emitting the #extension
directive in the output unless the extension is explicitly enabled or disabled
in the user's shader, which sounds good.

[Zhenyao Mo, 2011-08-09 14:06:05]

On Mon, Aug 8, 2011 at 8:57 AM,  <daniel@transgaming.com> wrote:
> Nothing too obvious jumping out at me.
>
> What are your plans for this?  Is this something you'll implement on the
> API-side as well or is this more just for the validator and ESSL-backend
> at this point?

This is for the validator and ESSL-backend.  Some of ANGLE clients
made the request.

>
> Note that Alok also has outstanding approved compiler changes so make
> sure you coordinate checkin with him.
>
>
>
>
> http://codereview.appspot.com/4809076/diff/3015/src/common/version.h
> File src/common/version.h (right):
>
> http://codereview.appspot.com/4809076/diff/3015/src/common/version.h#newcode4
> src/common/version.h:4: #define BUILD_REVISION 716
> beware of conflicts here, but due update this.
>
> http://codereview.appspot.com/4809076/diff/3015/src/compiler/Initialize.cpp
> File src/compiler/Initialize.cpp (right):
>
>
http://codereview.appspot.com/4809076/diff/3015/src/compiler/Initialize.cpp#n...
> src/compiler/Initialize.cpp:642:
> extBehavior["GL_OES_EGL_image_external"] = EBhUndefined;
> Extensions are supposed to be disabled unless they are explicitly
> enabled.  Does this change that?

No.  What Ken said.

>
> http://codereview.appspot.com/4809076/
>

[dgkoch, 2011-08-09 14:08:25]

Ok.  LGTM too then.