Issue 4809075: Changes to SkOSMenu

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4809075: Changes to SkOSMenu (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by yangsu

Modified:
13 years, 1 month ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : updated documentation #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -101 lines)			Patch
	M	include/views/SkOSMenu.h	View	1	4 chunks	+89 lines, -51 lines	0 comments	Download
	M	src/views/SkOSMenu.cpp	View	1	2 chunks	+110 lines, -50 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

yangsu

SkOSMenu changes to use the new SkEvents, cleaned up the helper functions

13 years, 1 month ago (2011-08-04 22:21:38 UTC) #1

reed1

Looks pretty great so far. http://codereview.appspot.com/4809075/diff/1/include/views/SkOSMenu.h File include/views/SkOSMenu.h (right): http://codereview.appspot.com/4809075/diff/1/include/views/SkOSMenu.h#newcode91 include/views/SkOSMenu.h:91: const Item* getItem(int index) ...

13 years, 1 month ago (2011-08-05 15:00:33 UTC) #2

yangsu

13 years, 1 month ago (2011-08-05 19:11:02 UTC) #3

http://codereview.appspot.com/4809075/diff/1/include/views/SkOSMenu.h
File include/views/SkOSMenu.h (right):

http://codereview.appspot.com/4809075/diff/1/include/views/SkOSMenu.h#newcode91
include/views/SkOSMenu.h:91: const Item* getItem(int index) const { return
fItems[index]; }
On 2011/08/05 15:00:33, reed1 wrote:
> Lets use 
> 
> /**
>  * This format for documenting methods.
>  */

Done.

http://codereview.appspot.com/4809075/diff/1/src/views/SkOSMenu.cpp
File src/views/SkOSMenu.cpp (right):

http://codereview.appspot.com/4809075/diff/1/src/views/SkOSMenu.cpp#newcode38
src/views/SkOSMenu.cpp:38: Item* item = fItems[i];
On 2011/08/05 15:00:33, reed1 wrote:
> nit: a little safer looking comparison is
> 
>     if (item->getKeyEquivalent() == key) {
> 
> so we can't accidentally use '=' instead of '=='

Done.

http://codereview.appspot.com/4809075/diff/1/src/views/SkOSMenu.cpp#newcode59
src/views/SkOSMenu.cpp:59: break;
On 2011/08/05 15:00:33, reed1 wrote:
> Is it sensible to post events for slider/text on a key-equivalent? Maybe, but
if
> so lets document that behavior.

Done.

http://codereview.appspot.com/4809075/diff/1/src/views/SkOSMenu.cpp#newcode195
src/views/SkOSMenu.cpp:195: 
On 2011/08/05 15:00:33, reed1 wrote:
> Do we document this syntax in the header?

Done.

Expand All Messages | Collapse All Messages