Issue 4809069: Add Commit to SkWIStream.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4809069: Add Commit to SkWIStream. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bungeman

Modified:
13 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	include/utils/win/SkIStream.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/utils/win/SkIStream.cpp	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

Add an implementation of IStream::Commit to SkWIStream to make sure the underlying SkWStream is flushed.

13 years, 4 months ago (2011-08-01 20:28:54 UTC) #1

reed1

LGTM http://codereview.appspot.com/4809069/diff/1/src/utils/win/SkIStream.cpp File src/utils/win/SkIStream.cpp (right): http://codereview.appspot.com/4809069/diff/1/src/utils/win/SkIStream.cpp#newcode244 src/utils/win/SkIStream.cpp:244: HRESULT STDMETHODCALLTYPE SkWIStream::Commit(DWORD) { don't need this-> for ...

13 years, 4 months ago (2011-08-01 20:33:47 UTC) #2

Committed revision 2017.

Expand All Messages | Collapse All Messages