Issue 4809053: Fix mem leak in font subsetting

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4809053: Fix mem leak in font subsetting (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by arthurhsu

Modified:
13 years, 4 months ago

Reviewers:
Steve VanDeBogart, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Fix mem leak in font subsetting BUG=none TEST=none Original issue http://codereview.appspot.com/4827041/ Break the comments from Mike into two CLs.

Patch Set 2 : Update per code review #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/pdf/SkPDFFont.cpp	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Steve VanDeBogart

http://codereview.appspot.com/4809053/diff/1/src/pdf/SkPDFFont.cpp File src/pdf/SkPDFFont.cpp (right): http://codereview.appspot.com/4809053/diff/1/src/pdf/SkPDFFont.cpp#newcode472 src/pdf/SkPDFFont.cpp:472: SkAutoTUnref<SkData> data(SkData::NewWithProc(subsetFont, Why not use SkAutoDataUnref ?

13 years, 4 months ago (2011-07-27 18:08:39 UTC) #2

arthurhsu

13 years, 4 months ago (2011-07-27 18:25:46 UTC) #3

LGTM - will commit

Expand All Messages | Collapse All Messages