Issue 4808081: More little improvements to bench_graph_svg.py

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4808081: More little improvements to bench_graph_svg.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by epoger

Modified:
13 years, 3 months ago

Reviewers:
bungeman

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

More little improvements to bench_graph_svg.py - add ability to express revision numbers as offset from latest - add configurable title Committed: http://code.google.com/p/skia/source/detail?r=2067

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -18 lines)			Patch
	M	bench/bench_graph_svg.py	View		9 chunks	+53 lines, -18 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bungeman

13 years, 3 months ago (2011-08-08 19:32:53 UTC) #2

Aside from get_latest_revision's location, LGTM.

http://codereview.appspot.com/4808081/diff/1/bench/bench_graph_svg.py
File bench/bench_graph_svg.py (right):

http://codereview.appspot.com/4808081/diff/1/bench/bench_graph_svg.py#newcode70
bench/bench_graph_svg.py:70: def get_latest_revision(directory):
This function should probably go in bench_util, next to parse_dir, so that way
all the related bits are together.

Expand All Messages | Collapse All Messages