Issue 4808058: Add a test for drawBitmap to SampleApp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4808058: Add a test for drawBitmap to SampleApp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by junov1

Modified:
13 years, 5 months ago

Reviewers:
junov, bsalomon, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -0 lines)			Patch
	M	gyp/SampleApp.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	samplecode/SampleDrawBitmap.cpp	View		1 chunk	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

On 2011/07/28 13:00:22, bsalomon wrote: > On 2011/07/27 21:45:27, junov1 wrote: > > PTAL > ...

13 years, 5 months ago (2011-07-28 13:09:06 UTC) #4

junov

13 years, 5 months ago (2011-07-28 13:28:51 UTC) #5

Yes, except that propagating it correctly is tricky. I commented in
issue 332 with a suggestion to that effect.

On Thu, Jul 28, 2011 at 9:09 AM,  <bsalomon@google.com> wrote:
> On 2011/07/28 13:00:22, bsalomon wrote:
>>
>> On 2011/07/27 21:45:27, junov1 wrote:
>> > PTAL
>
>
>
> Would having SkBitmap::getTexture and SkAutoCachedTexture give an x,y
> offset (or a rect) be a sufficient fix for this?
>
> http://codereview.appspot.com/4808058/
>

Expand All Messages | Collapse All Messages