Add isRect to SkPath

[reed1, 2011-07-26 19:10:13]

LGTM

Not important, but

1. we could detect collinear quads and cubics, and fall through to the line code
in those cases

2. If the API passed in fill or stroke, we could return true for some (fill)
paths where the caller left off the close, but filling will close it for us.

http://codereview.appspot.com/4807052/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

http://codereview.appspot.com/4807052/diff/1/src/core/SkPath.cpp#newcode286
src/core/SkPath.cpp:286: // Success if 4 corners and first point equals last
I think first == last will work for SkPoints.

[caryclark1, 2011-07-26 19:31:30]

this version doesn't use SkPath::Iter

[reed1, 2011-07-26 19:41:29]

LGTM

http://codereview.appspot.com/4807052/diff/8001/src/core/SkPath.cpp
File src/core/SkPath.cpp (left):

http://codereview.appspot.com/4807052/diff/8001/src/core/SkPath.cpp#oldcode193
src/core/SkPath.cpp:193: return false;
don't need iter

http://codereview.appspot.com/4807052/diff/8001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

http://codereview.appspot.com/4807052/diff/8001/src/core/SkPath.cpp#newcode291
src/core/SkPath.cpp:291: case kMove_Verb:
last = *pts++;

[caryclark1, 2011-07-26 19:48:50]

http://codereview.appspot.com/4807052/diff/8001/src/core/SkPath.cpp
File src/core/SkPath.cpp (left):

http://codereview.appspot.com/4807052/diff/8001/src/core/SkPath.cpp#oldcode193
src/core/SkPath.cpp:193: return false;
On 2011/07/26 19:41:29, reed1 wrote:
> don't need iter

Done.

http://codereview.appspot.com/4807052/diff/8001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

http://codereview.appspot.com/4807052/diff/8001/src/core/SkPath.cpp#newcode291
src/core/SkPath.cpp:291: case kMove_Verb:
On 2011/07/26 19:41:29, reed1 wrote:
> last = *pts++;

Done.

[caryclark1, 2011-07-26 19:49:34]

http://codereview.appspot.com/4807052/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

http://codereview.appspot.com/4807052/diff/1/src/core/SkPath.cpp#newcode286
src/core/SkPath.cpp:286: // Success if 4 corners and first point equals last
On 2011/07/26 19:10:13, reed1 wrote:
> I think first == last will work for SkPoints.

Done.