Issue 4807051: Revert "Add sizeInBytes to GrResource, make GrRenderTarget aware of its pixel config (r1951)"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4807051: Revert "Add sizeInBytes to GrResource, make GrRenderTarget aware of its pixel config (r1951)" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Steve VanDeBogart

Modified:
13 years, 3 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Revert "Add sizeInBytes to GrResource, make GrRenderTarget aware of its pixel config (r1951)" Temporarily revert this change in order to roll other changes into Chrome. TBR=bsalomon@google.com Committed: http://code.google.com/p/skia/source/detail?r=1958

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -312 lines)			Patch
M	gpu/include/GrGLConfig.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	gpu/include/GrGLDefines.h	View	4 chunks	+9 lines, -22 lines	0 comments	Download
M	gpu/include/GrGLInterface.h	View	4 chunks	+0 lines, -6 lines	0 comments	Download
M	gpu/include/GrGLTexture.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	gpu/include/GrGeometryBuffer.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	gpu/include/GrIndexBuffer.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	gpu/include/GrResource.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	gpu/include/GrTexture.h	View	7 chunks	+8 lines, -21 lines	0 comments	Download
M	gpu/src/GrBufferAllocPool.cpp	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	gpu/src/GrDrawTarget.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/src/GrGLIndexBuffer.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	gpu/src/GrGLInterface.cpp	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	gpu/src/GrGLTexture.cpp	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	gpu/src/GrGLVertexBuffer.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View	2 chunks	+6 lines, -158 lines	0 comments	Download
M	gpu/src/GrTextContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrTexture.cpp	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	gpu/src/android/GrGLDefaultInterface_android.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	gpu/src/ios/GrGLDefaultInterface_iOS.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gpu/src/mac/GrGLDefaultInterface_mac.cpp	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	gpu/src/mesa/GrGLDefaultInterface_mesa.cpp	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	gpu/src/unix/GrGLDefaultInterface_unix.cpp	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	gpu/src/win/GrGLDefaultInterface_win.cpp	View	3 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

13 years, 3 months ago (2011-07-26 12:13:22 UTC) #2

On 2011/07/26 03:43:50, Steve VanDeBogart wrote:

I don't understand why this was done. Was there a pressing need to get something
into Chrome yesterday evening? It doesn't look there was a DEPS roll including
this change. I have a roll to r1951 that passed the bots ready to checkin this
morning with Chrome changes required by r1951. I am going to commit it and
reapply this change to TOT to prepare the next roll.

Expand All Messages | Collapse All Messages