Add sizeInBytes to GrResource, make GrRenderTarget aware of its pixel config.

This is the first of a series of changes to make Gr able to manage stencil buffers more dynamically. This change makes the resource size a base class query. The next change will use this to turn GrTextureCache into GrResourceCache (which will eventually also manage a new GrStencilBuffer class).

It also makes GrRenderTarget aware of its pixel config. It is a bit hairy to figure out the pixel config from the current GL state, hence all the new GL code and added GL enums/func ptrs.

[reed1, 2011-07-25 14:38:59]

defers to Tom

[TomH, 2011-07-25 15:53:21]

Do we need an implementation in android/GrGLDefaultInterface?

Otherwise LGTM. Nits to follow:

http://codereview.appspot.com/4802058/diff/5001/gpu/src/GrGLIndexBuffer.cpp
File gpu/src/GrGLIndexBuffer.cpp (right):

http://codereview.appspot.com/4802058/diff/5001/gpu/src/GrGLIndexBuffer.cpp#n...
gpu/src/GrGLIndexBuffer.cpp:63: this->dynamic() ? GR_GL_DYNAMIC_DRAW :
GR_GL_STATIC_DRAW));
Am I forgetting something in the style guide that encourages all the additions
of "this->"?

http://codereview.appspot.com/4802058/diff/5001/gpu/src/GrGpuGL.cpp
File gpu/src/GrGpuGL.cpp (right):

http://codereview.appspot.com/4802058/diff/5001/gpu/src/GrGpuGL.cpp#newcode757
gpu/src/GrGpuGL.cpp:757: GrPixelConfig get_implied_color_config(bool arbFBO) {
Could the name of the parameter make its meaning clearer? Reading the code below
isn't helping me understand why...

(EDIT: OK, after rereading I can guess, and reading ahead to
onCreateRenderTargetFrom3DApiState() makes it pretty clear.)

[bsalomon, 2011-07-25 17:02:36]

On 2011/07/25 15:53:21, TomH wrote:
> Do we need an implementation in android/GrGLDefaultInterface?
> 

Yes, nice catch, added it.

>
http://codereview.appspot.com/4802058/diff/5001/gpu/src/GrGLIndexBuffer.cpp#n...
> gpu/src/GrGLIndexBuffer.cpp:63: this->dynamic() ? GR_GL_DYNAMIC_DRAW :
> GR_GL_STATIC_DRAW));
> Am I forgetting something in the style guide that encourages all the additions
> of "this->"?

The style guide said we should use "this->" for virtual functions but I just
modified it to say all methods.

http://codereview.appspot.com/4802058/diff/5001/gpu/src/GrGpuGL.cpp#newcode757
> gpu/src/GrGpuGL.cpp:757: GrPixelConfig get_implied_color_config(bool arbFBO) {
> Could the name of the parameter make its meaning clearer? Reading the code
below
> isn't helping me understand why...
> 
> (EDIT: OK, after rereading I can guess, and reading ahead to
> onCreateRenderTargetFrom3DApiState() makes it pretty clear.)

I changed the param name to arbFBOExtension so its a little clearer.

[bsalomon, 2011-07-25 18:18:06]

Closed with r1951