Issue 4801088: Add means to release object from ScopedComPtr.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4801088: Add means to release object from ScopedComPtr. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by bungeman

Modified:
12 years, 11 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	include/utils/win/SkTScopedComPtr.h	View		2 chunks	+7 lines, -4 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

LGTM http://codereview.appspot.com/4801088/diff/1/include/utils/win/SkTScopedComPtr.h File include/utils/win/SkTScopedComPtr.h (right): http://codereview.appspot.com/4801088/diff/1/include/utils/win/SkTScopedComPtr.h#newcode35 include/utils/win/SkTScopedComPtr.h:35: void reset() { this->methods() should have this-> fFields ...

12 years, 11 months ago (2011-08-09 19:09:15 UTC) #2

Committed revision 2090.

Expand All Messages | Collapse All Messages