Issue 4801084: General cleanup of compiler directory and ParseHelper.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4801084: General cleanup of compiler directory and ParseHelper. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Alok Priyadarshi

Modified:
12 years, 8 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

General cleanup of compiler directory and ParseHelper. Committed: http://code.google.com/p/angleproject/source/detail?r=730

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -46 lines)			Patch
M	src/compiler/ParseHelper.h	View	5 chunks	+13 lines, -11 lines	0 comments	Download
M	src/compiler/ParseHelper.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/compiler/generate_glslang_lexer.sh	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	src/compiler/generate_glslang_parser.sh	View	1 chunk	+0 lines, -12 lines	0 comments	Download
A	src/compiler/generate_parser.sh	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	src/compiler/glslang.l	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/glslang.y	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/glslang_lex.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/glslang_tab.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/glslang_tab.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2

dgkoch

12 years, 9 months ago (2011-08-08 15:26:35 UTC) #2

LGTM 

(don't forget to bump BUILD_REVISION in src/common/version.h when you commit).