Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(345)

Issue 4798063: Incorporates suggestions from Neil into footnotes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by MikeSol
Modified:
12 years, 8 months ago
Reviewers:
mike, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Incorporates suggestions from Neil into footnotes.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M input/regression/footnote-auto-numbering.ly View 1 chunk +5 lines, -1 line 0 comments Download
M input/regression/footnote-auto-numbering-page-reset.ly View 1 chunk +6 lines, -1 line 0 comments Download
M ly/music-functions-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M scm/lily-library.scm View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4
MikeSol
Hey all, These incorporate several comments from Neil regarding automatic footnotes. Sorry for having missed ...
12 years, 8 months ago (2011-07-31 10:46:54 UTC) #1
MikeSol
On 2011/07/31 10:46:54, MikeSol wrote: > Hey all, > > These incorporate several comments from ...
12 years, 8 months ago (2011-07-31 17:27:58 UTC) #2
Neil Puttock
On 2011/07/31 10:46:54, MikeSol wrote: > Sorry for having missed them before, Neil! Thanks for ...
12 years, 8 months ago (2011-08-01 20:50:09 UTC) #3
mike_apollinemike.com
12 years, 8 months ago (2011-08-01 21:50:43 UTC) #4
Not a prob, Neil.  Pushed as 4ed502a165b3c9a1a65b4632b1e6db91c9655848.

I'll try to get a patch up for the footer problem before I go to bed.

Cheers,
MS

On Aug 1, 2011, at 9:50 PM, n.puttock@gmail.com wrote:

> On 2011/07/31 10:46:54, MikeSol wrote:
> 
>> Sorry for having missed them before, Neil!
> 
> Thanks for sorting these.
> 
> BTW, you'll probably be interested in this post from lilypond-user-fr:
> 
> http://lists.gnu.org/archive/html/lilypond-user-fr/2011-07/msg00127.html
> 
> It looks like we need a check to ensure the footer stencil actually
> exists.
> 
> Cheers,
> Neil
> 
> 
> http://codereview.appspot.com/4798063/

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b