Issue 4798041: GPU blur fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4798041: GPU blur fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Stephen White

Modified:
13 years, 3 months ago

Reviewers:
bsalomon

CC:
reed1, skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Sometimes, the cache serves us textures of different sizes for srcTexture and dstTexture (this is fair; they're supposed to be approximate). Code was assuming otherwise while downsampling; fix is to reapply the scale on each downsample. (Yes, I could cache these reciprocals if and when they prove to be a hot spot). Also, use setIDiv(w,h) everywhere for conciseness.

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
		src/gpu/SkGpuDevice.cpp	View		4 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

On 2011/07/19 21:16:28, Stephen White wrote: The age of setIDiv is here. LGTM.

13 years, 3 months ago (2011-07-19 21:19:38 UTC) #2

Stephen White

13 years, 3 months ago (2011-07-19 21:28:23 UTC) #3

On 2011/07/19 21:19:38, bsalomon wrote:
> On 2011/07/19 21:16:28, Stephen White wrote:
> 
> The age of setIDiv is here.

("When the moon .. is in the seventh house...")

Indeed!  Thanks for that!

> 
> LGTM.

Landed as r1907.  Closing.

Expand All Messages | Collapse All Messages