Cleanup from r1843 based on revision comments.

Cleanup from r1843 based on revision comments.
Committed: http://code.google.com/p/skia/source/detail?r=1966

[Steve VanDeBogart, 2011-07-21 18:33:11]

http://codereview.appspot.com/4794044/diff/1/include/pdf/SkPDFDevice.h
File include/pdf/SkPDFDevice.h (right):

http://codereview.appspot.com/4794044/diff/1/include/pdf/SkPDFDevice.h#newcod...
include/pdf/SkPDFDevice.h:120: *  area is the content drawing area.
However, these is still a bug, which we should document here.  If margin content
is drawn and then a complex (for PDF) xfer mode is used, like SrcIn, Clear, etc,
the margin content will get clipped. A simple way to avoid the bug is to always
draw the margin content last.

http://codereview.appspot.com/4794044/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/4794044/diff/1/src/pdf/SkPDFDevice.cpp#newcode85
src/pdf/SkPDFDevice.cpp:85: const char* start = reinterpret_cast<const
char*>(glyphs);
Skia generally uses C style casts

http://codereview.appspot.com/4794044/diff/1/src/pdf/SkPDFDevice.cpp#newcode554
src/pdf/SkPDFDevice.cpp:554: // TODO(ctguil): Actually, we don't want to reset
the margin content on
Aayush convinced me that this isn't as bad as I thought.  We do want to reset
these on init().

[reed1, 2011-07-21 19:40:16]

skia is starting to migrate to fancy-pants casts (reinterpret, static, etc) so
you can keep those if you already have them.

[Steve VanDeBogart, 2011-07-26 23:29:25]

ping.

[Chris Guillory, 2011-07-26 23:44:29]

http://codereview.appspot.com/4794044/diff/1/include/pdf/SkPDFDevice.h
File include/pdf/SkPDFDevice.h (right):

http://codereview.appspot.com/4794044/diff/1/include/pdf/SkPDFDevice.h#newcod...
include/pdf/SkPDFDevice.h:120: *  area is the content drawing area.
On 2011/07/21 18:33:11, Steve VanDeBogart wrote:
> However, these is still a bug, which we should document here.  If margin
content
> is drawn and then a complex (for PDF) xfer mode is used, like SrcIn, Clear,
etc,
> the margin content will get clipped. A simple way to avoid the bug is to
always
> draw the margin content last.

Done.

http://codereview.appspot.com/4794044/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/4794044/diff/1/src/pdf/SkPDFDevice.cpp#newcode85
src/pdf/SkPDFDevice.cpp:85: const char* start = reinterpret_cast<const
char*>(glyphs);
On 2011/07/21 18:33:11, Steve VanDeBogart wrote:
> Skia generally uses C style casts
Keeping C++ style per Mike's comment.

http://codereview.appspot.com/4794044/diff/1/src/pdf/SkPDFDevice.cpp#newcode554
src/pdf/SkPDFDevice.cpp:554: // TODO(ctguil): Actually, we don't want to reset
the margin content on
On 2011/07/21 18:33:11, Steve VanDeBogart wrote:
> Aayush convinced me that this isn't as bad as I thought.  We do want to reset
> these on init().

Done.

[Steve VanDeBogart, 2011-07-26 23:55:35]

LGTM