Issue 4784043: Enable GPU blur by default; provide a global #define to disable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4784043: Enable GPU blur by default; provide a global #define to disable (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Stephen White

Modified:
13 years, 3 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Enable the GPU-based blur by default in Skia, and provide a #define to disable it (SK_DISABLE_GPU_BLUR).

Patch Set 1 #

Patch Set 2 : Remove the changes to SkUserConfig; flip the default to on in Skia. #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
		src/gpu/SkGpuDevice.cpp	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Stephen White

Remove the changes to SkUserConfig; flip the default to on in Skia.

13 years, 3 months ago (2011-07-19 16:22:55 UTC) #2

Stephen White

On 2011/07/19 16:24:04, reed1 wrote: > LGTM -- bring on the rebaselines! OK. I'll land ...

13 years, 3 months ago (2011-07-19 16:34:09 UTC) #4

Stephen White

13 years, 3 months ago (2011-07-19 16:41:53 UTC) #5

On 2011/07/19 16:34:09, Stephen White wrote:
> On 2011/07/19 16:24:04, reed1 wrote:
> > LGTM -- bring on the rebaselines!
> 
> OK.  I'll land with MacPro float to avoid at least some bustage.  If you could
> handle the Linux ones, that'd be great.

Landed as r1901.  Closing.

Expand All Messages | Collapse All Messages