Issue 4769041: [PATCH] Add APInt::getSigned(bits, value)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4769041: [PATCH] Add APInt::getSigned(bits, value)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by Jeffrey Yasskin

Modified:
14 years, 3 months ago

Reviewers:

Visibility:
Public.

Description

Add APInt::getSigned(bits, value) to avoid ambiguity between the APInt(bits, uint64_t, bool) and APInt(bits, unsigned, uint64_t*) constructors. Deprecate both of those constructors, and update LLVM's calls to them.

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fixes #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -34 lines)			Patch
M	docs/ReleaseNotes.html	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	include/llvm/ADT/APInt.h	View	1	4 chunks	+19 lines, -5 lines	0 comments	Download
M	lib/ExecutionEngine/ExecutionEngineBindings.cpp	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/Support/APInt.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/Target/CellSPU/SPUISelLowering.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/Transforms/InstCombine/InstCombineMulDivRem.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	lib/Transforms/Scalar/LoopStrengthReduce.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/VMCore/Constants.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	unittests/ADT/APFloatTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	unittests/ADT/APIntTest.cpp	View	1	8 chunks	+17 lines, -17 lines	0 comments	Download
M	unittests/Support/ConstantRangeTest.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download