Issue 4763047: [PDF] Add setPage method to SkPDFDocument.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4763047: [PDF] Add setPage method to SkPDFDocument. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Steve VanDeBogart

Modified:
12 years, 11 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com, kmadhusu_chromium.org

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Add setPage method to SkPDFDocument. BUG=312 Committed: http://code.google.com/p/skia/source/detail?r=1892

Patch Set 2 : Address comments #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -8 lines)			Patch
M	include/pdf/SkPDFDocument.h	View		1 chunk	+14 lines, -1 line	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	1	2 chunks	+32 lines, -7 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Chris Guillory

LGTM http://codereview.appspot.com/4763047/diff/1/src/pdf/SkPDFDocument.cpp File src/pdf/SkPDFDocument.cpp (right): http://codereview.appspot.com/4763047/diff/1/src/pdf/SkPDFDocument.cpp#newcode62 src/pdf/SkPDFDocument.cpp:62: for (int i = 0; i < fPages.count(); ...

12 years, 11 months ago (2011-07-18 23:03:20 UTC) #2

Steve VanDeBogart

12 years, 11 months ago (2011-07-18 23:13:07 UTC) #3

http://codereview.appspot.com/4763047/diff/1/src/pdf/SkPDFDocument.cpp
File src/pdf/SkPDFDocument.cpp (right):

http://codereview.appspot.com/4763047/diff/1/src/pdf/SkPDFDocument.cpp#newcod...
src/pdf/SkPDFDocument.cpp:158: if (fPageTree.count() != 0)
On 2011/07/18 23:03:20, Chris Guillory wrote:
> Braces needed.

Done.

Expand All Messages | Collapse All Messages