Issue 4757050: Use approx texture for writePixels

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4757050: Use approx texture for writePixels (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by bsalomon

Modified:
12 years, 11 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/gpu/src/

Visibility:
Public.

Patch Set 2 : add setIDiv to SkMatrix #

Total comments: 1

Patch Set 3 : make setIDiv always set the matrix (and use setScale) #

Patch Set 4 : return false and leave matrix unmodified if divx or divy is zero #

Patch Set 5 : return true on success #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -5 lines)			Patch
M	gpu/src/GrContext.cpp	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	include/core/SkMatrix.h	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/core/SkMatrix.cpp	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/4757050/diff/2001/src/core/SkMatrix.cpp File src/core/SkMatrix.cpp (left): http://codereview.appspot.com/4757050/diff/2001/src/core/SkMatrix.cpp#oldcode222 src/core/SkMatrix.cpp:222: If either are zero, now the matrix is uninitialized ...

12 years, 11 months ago (2011-07-18 18:36:28 UTC) #3

bsalomon

makes setIDiv return a bool rather than turn 1/0 into 1.

12 years, 11 months ago (2011-07-18 18:57:41 UTC) #5

Closed with r1887 (verbal lgtm from Mike)

Expand All Messages | Collapse All Messages