Issue 4757043: MIDI: reset channel counters when done; issue 1678

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4757043: MIDI: reset channel counters when done; issue 1678 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Keith

Modified:
13 years, 9 months ago

Reviewers:
pkx166h, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

MIDI: reset channel counters when done; issue 1678

Patch Set 1 #

Total comments: 1

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	lily/staff-performer.cc	View		3 chunks	+14 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

pkx166h

Passes Make tests - I still get: --snip-- @ -1,8 +1,6 @@ Parsing... Renaming input ...

13 years, 9 months ago (2011-07-16 15:11:02 UTC) #1

Neil Puttock

13 years, 9 months ago (2011-07-21 17:53:53 UTC) #2

LGTM.

http://codereview.appspot.com/4757043/diff/1/lily/staff-performer.cc
File lily/staff-performer.cc (right):

http://codereview.appspot.com/4757043/diff/1/lily/staff-performer.cc#newcode69
lily/staff-performer.cc:69: // For now, ask the last Staff_performer clean up
during its finalize()
finalize ()

Expand All Messages | Collapse All Messages