Issue 4750041: Add ibus-dconf.

Issue 4750041: Add ibus-dconf. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Daiki Ueno

Modified:
12 years, 11 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add ibus-dconf. BUG=https://code.google.com/p/ibus/issues/detail?id=1235 TEST=manually with "make check" and interactive testing

Patch Set 2 : do cleanup when db/ibus creation failed, and fix dconf.xml.in.in #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+704 lines, -22 lines)			Patch
M	Makefile.am	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	configure.ac	View		4 chunks	+22 lines, -0 lines	0 comments	Download
M	data/Makefile.am	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	data/dconf/Makefile.am	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
A	data/dconf/ibus.convert	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	data/dconf/make-dconf-override-db.sh	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	data/dconf/profile/ibus	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	data/ibus.schemas.in	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	dconf/Makefile.am	View		1 chunk	+54 lines, -22 lines	0 comments	Download
A	dconf/config.h	View		1 chunk	+47 lines, -0 lines	0 comments	Download
A	dconf/config.c	View		1 chunk	+354 lines, -0 lines	0 comments	Download
A	dconf/dconf.xml.in.in	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
A	dconf/main.c	View		1 chunk	+87 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/4750041/diff/1/data/dconf/Makefile.am File data/dconf/Makefile.am (right): https://codereview.appspot.com/4750041/diff/1/data/dconf/Makefile.am#newcode55 data/dconf/Makefile.am:55: @$(mkdir_p) db Use $(MKDIR_P). https://codereview.appspot.com/4750041/diff/1/data/dconf/Makefile.am#newcode56 data/dconf/Makefile.am:56: $(AM_V_GEN) $(srcdir)/make-dconf-override-db.sh $@ ...

12 years, 11 months ago (2011-07-15 14:06:36 UTC) #2

Daiki Ueno

Thanks for the review. On 2011/07/15 14:06:36, Peng wrote: > https://codereview.appspot.com/4750041/diff/1/data/dconf/Makefile.am > File data/dconf/Makefile.am (right): ...

12 years, 11 months ago (2011-07-18 01:14:38 UTC) #3

Peng

12 years, 11 months ago (2011-07-18 02:49:04 UTC) #4

LGTM

On 2011/07/18 01:14:38, Daiki Ueno wrote:
> Thanks for the review.
> 
> On 2011/07/15 14:06:36, Peng wrote:
> > https://codereview.appspot.com/4750041/diff/1/data/dconf/Makefile.am
> > File data/dconf/Makefile.am (right):
> > 
> >
https://codereview.appspot.com/4750041/diff/1/data/dconf/Makefile.am#newcode55
> > data/dconf/Makefile.am:55: @$(mkdir_p) db
> > Use $(MKDIR_P).
> 
> Done.
> 
> >
https://codereview.appspot.com/4750041/diff/1/data/dconf/Makefile.am#newcode56
> > data/dconf/Makefile.am:56: $(AM_V_GEN) $(srcdir)/make-dconf-override-db.sh
$@
> > I think you should test the result of commends. If some errors happen, you
> need
> > do some clean up.
> > for example:
> > (cmd1 && cmd2 && cmd3 ) || ( $(RM) $@; exit 1)
> 
> Done.
> 
> > https://codereview.appspot.com/4750041/diff/1/dconf/dconf.xml.in.in
> > File dconf/dconf.xml.in.in (right):
> > 
> > https://codereview.appspot.com/4750041/diff/1/dconf/dconf.xml.in.in#newcode2
> > dconf/dconf.xml.in.in:2: <!-- filename: pinyin.xml -->
> > pinyin.xml?
> 
> Fixed.
> 
> > https://codereview.appspot.com/4750041/diff/1/dconf/dconf.xml.in.in#newcode8
> > dconf/dconf.xml.in.in:8: <author>Peng Huang
> > &lt;shawn.p.huang@gmail.com&gt;</author>
> > Change the author
> 
> Fixed.

Expand All Messages | Collapse All Messages