Make CPU->GPU blur path use texture cache

[bsalomon, 2011-07-14 15:25:30]

I got a complaint about lots of texture creates for blurs from someone using the
fixed-pipe code (so they won't be able to take advantage of gpu-blur when its
enabled).

Note: I already submitted this change to GrAutoUnlockTextureEntry: 
http://code.google.com/p/skia/source/diff?spec=svn1858&r=1858&format=side&pat...
I accidentally checked in as part of an unrelated change, oops!

[Stephen White, 2011-07-14 15:32:30]

LGTM

http://codereview.appspot.com/4730041/diff/2001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

http://codereview.appspot.com/4730041/diff/2001/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:1075: context->findApproximateKeylessTexture(desc));
On a related note, I was thinking we should probably change this to be a proper
RAII class (GrAutoKeylessTextureEntry or something), and have it do the find..()
call as well.  WDYT?

[reed1, 2011-07-14 15:39:05]

looking forward to the next evolutionary step in our API for hiding
implementation details (cached or not) and intents (scratch, temp, etc.)

LGTM

[bsalomon, 2011-07-14 15:42:22]

On Thu, Jul 14, 2011 at 11:32 AM, <senorblanco@chromium.org> wrote:

> http://codereview.appspot.com/**4730041/diff/2001/src/gpu/**
>
SkGpuDevice.cpp#newcode1075<http://codereview.appspot.com/4730041/diff/2001/src/gpu/SkGpuDevice.cpp#newcode1075>
> src/gpu/SkGpuDevice.cpp:1075:
> context->**findApproximateKeylessTexture(**desc));
> On a related note, I was thinking we should probably change this to be a
> proper RAII class (GrAutoKeylessTextureEntry or something), and have it
> do the find..() call as well.  WDYT?
>
>
>
http://codereview.appspot.com/**4730041/<http://codereview.appspot.com/4730041/>
>

Yeah I think we need to rethink the APIs for creating / locking textures.
The names are bad and its silly to have to call a function and then hand the
result to the auto unlocker.

I'm thinking something like:
AutoScratchTexture ast(context, desc, kApprox_TexMatch);

[bsalomon, 2011-07-14 15:46:06]

closed with r1860.