Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2130)

Issue 4718041: Remove unused SkGpuDevice functions, add GrRenderTarget handle getters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by bsalomon
Modified:
12 years, 11 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add RT handle getters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M gpu/include/GrGLTexture.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/include/GrTexture.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3
bsalomon
getLayerTextureHandle is non-virtual, a weird name, and we already have SkDevice::accessTexture()->getTextureHandle(); scissor() is declared but ...
12 years, 11 months ago (2011-07-13 19:21:03 UTC) #1
reed1
I love to see code deletions. LGTM
12 years, 11 months ago (2011-07-13 19:52:35 UTC) #2
bsalomon
12 years, 11 months ago (2011-07-13 21:58:03 UTC) #3
Closed with r1854
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b