Issue 4717044: enable "make XXX" command-line builds on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4717044: enable "make XXX" command-line builds on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by epoger

Modified:
13 years, 5 months ago

Reviewers:
bungeman

CC:
vandebo (use chromium instead), reed1, skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

with this change, you can build and run tests like this from the Windows command prompt: > make clean > make tests > out\Debug\tests highlighted changes: - update gyp to 940 and use new msvs_abspath_output flag to work around path error in gyp - set msvs_version as a flag rather than setting the developer’s GYP_MSVS_VERSION environment variable - copy built binaries into out\$BUILDTYPE (e.g. out\Debug) - report error if run under Cygwin (we may support Cygwin at some point, but we don’t yet)

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -10 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp_skia	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	make.bat	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	make.py	View	5 chunks	+30 lines, -7 lines	0 comments	Download
M	third_party/externals	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

committed as r1853

Expand All Messages | Collapse All Messages