fodt parsing with Relatorio

[ced, 2011-07-14 10:35:40]

http://codereview.appspot.com/4717041/diff/7/relatorio/templates/opendocument.py
File relatorio/templates/opendocument.py (right):

http://codereview.appspot.com/4717041/diff/7/relatorio/templates/opendocument...
relatorio/templates/opendocument.py:48: import xml.dom.minidom
Don't use minidom, use lxml

http://codereview.appspot.com/4717041/diff/7/relatorio/templates/opendocument...
relatorio/templates/opendocument.py:267: meta = file('meta.xml', 'w')
I think you can use StringIO instead of real file.

http://codereview.appspot.com/4717041/diff/7/relatorio/templates/opendocument...
relatorio/templates/opendocument.py:268: for node in
dom.getElementsByTagName('office:meta'):# visit every node <office:meta />
Fit to 80cols

http://codereview.appspot.com/4717041/diff/7/relatorio/templates/opendocument...
relatorio/templates/opendocument.py:321: #        content = ('<?xml
version="1.0" encoding="UTF-8"?> \n <office:document-content
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0"
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0"
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0"
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0"
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"
xmlns:xlink="http://www.w3.org/1999/xlink"
xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0"
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0"
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0"
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0"
xmlns:math="http://www.w3.org/1998/Math/MathML"
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0"
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
xmlns:ooo="http://openoffice.org/2004/office"
xmlns:ooow="http://openoffice.org/2004/writer"
xmlns:oooc="http://openoffice.org/2004/calc"
xmlns:dom="http://www.w3.org/2001/xml-events"
xmlns:xforms="http://www.w3.org/2002/xforms"
xmlns:xsd="http://www.w3.org/2001/XMLSchema"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:rpt="http://openoffice.org/2005/report"
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2"
xmlns:rdfa="http://docs.oasis-open.org/opendocument/meta/rdfa#"
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0"
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
office:version="1.2">' + content1 + content2 + content3 + content4 +
'</office:document-content>')
Remove comments

http://codereview.appspot.com/4717041/diff/7/relatorio/templates/opendocument...
relatorio/templates/opendocument.py:327: def _parseFODT(self, source, encoding):
I think you can merge with _parse by doing ducktyping on zipfile.ZipFile

http://codereview.appspot.com/4717041/diff/7/relatorio/templates/opendocument...
relatorio/templates/opendocument.py:366: print io
not useful

http://codereview.appspot.com/4717041/diff/7/relatorio/tests/test_odt.py
File relatorio/tests/test_odt.py (right):

http://codereview.appspot.com/4717041/diff/7/relatorio/tests/test_odt.py#newc...
relatorio/tests/test_odt.py:58: # change test.odt to test.fodt to make test for
fodt format
You could perhaps make a loop to test both format type.

http://codereview.appspot.com/4717041/diff/7/relatorio/tests/test_odt.py#newc...
relatorio/tests/test_odt.py:314: if __name__ == '__main__':
No need of that to run the tests:
    python setup.py test

[ced, 2011-08-14 10:30:31]

https://codereview.appspot.com/4717041/diff/27001/relatorio/templates/opendoc...
File relatorio/templates/opendocument.py (right):

https://codereview.appspot.com/4717041/diff/27001/relatorio/templates/opendoc...
relatorio/templates/opendocument.py:89: from lxml import etree
Why not use lxml.etree imported above?

https://codereview.appspot.com/4717041/diff/27001/relatorio/templates/opendoc...
relatorio/templates/opendocument.py:90: class MyZip(zipfile.ZipFile):
I don't like the behavior of this class because it doesn't call ZipFile.__init__
in each cases. Then it can have strang behavior, because dev will expect it is a
ZipFile.
I think the best is to construct the zipfile if it is a flatten file.

https://codereview.appspot.com/4717041/diff/27001/relatorio/templates/opendoc...
relatorio/templates/opendocument.py:100: if extension.upper() == self.FODT:
Could not the test be made on a test if it is a zipped file or not. Because
extensions are not always reliable and relatorio doesn't parse only odt file but
kind of OpenDocument like odc, ods etc.

https://codereview.appspot.com/4717041/diff/27001/relatorio/templates/opendoc...
relatorio/templates/opendocument.py:108: parser =
etree.XMLParser(remove_blank_text = True)
Why removing blank_text?

https://codereview.appspot.com/4717041/diff/27001/relatorio/templates/opendoc...
relatorio/templates/opendocument.py:111: meta = (root.getroot())[0]
Must use tag name